8 parts · 13 chapters

Code Review and Merge Discipline

Code review is where a team's standards are actually set: not in the style guide, but in what reviewers approve. Done well it spreads knowledge, catches the bugs tests miss, and teaches; done badly it is a slow gate that argues about commas.

Eight parts: what review is for and not for; an order for reading a pull request; writing feedback people act on; receiving feedback; PR size, stacking and descriptions; merge strategies and branch protection; review at scale with owners, SLAs, bots and AI reviewers; and review as teaching and as a staff signal.

what review is for · an order of reading · feedback people act on · receiving feedback · PR size and descriptions · merge strategies · review at scale · review as teachingeveryone · engineers who review or are reviewed (everyone)
purposeCorrectness, design, knowledge sharing and standards, in that order.
readingDescription, tests, the core change, then the rest.
feedbackSpecific, kind, labelled by severity, with the why.
sizeSmall PRs, stacked changes, descriptions that explain.
mergingMerge, squash and rebase; protected branches and required checks.
scaleCODEOWNERS, review SLAs, bots and AI reviewers.
Pairs with Big-company FE and AI-nativeBig-company FE part 7 covered review culture; AI-native part 4 covered agent PR critique. This course is the craft itself.